Get the toggle_prismicStage cookie and set the prismic env via process.env #10869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y via process.env
19 tasks
|
Size Change: +140 B (+0.01%) Total Size: 972 kB
ℹ️ View Unchanged
|
rcantin-w
reviewed
May 22, 2024
common/koa-middleware/prismicEnv.ts
Outdated
Comment on lines
9
to
11
| const noisyUrl = | ||
| ctx.request.url === '/account/api/auth/me' || | ||
| ctx.request.url.match(/_next.*/); |
rcantin-w
approved these changes
May 22, 2024
agnesgaroux
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Who is this for?
People who want to test Prismic stage content
What is it doing for them?
Setting the prismic repository endpoint based on the presence of the
prismicStagetoggleOur standard means of accessing the toggles isn't available in the context that we set the prismic repository. I've added a
PRISMIC_ENVkey to the nodeprocess.envat the point we can first read the toggle (cookie) values with Koa. Not sure if this is the best approach, but I ended up chasing my tail trying to find a way to pass the value in where it was needed another way.