Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont transform classes #6

Merged
merged 2 commits into from
Jan 19, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 15 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,21 @@ if (process.env.NODE_ENV !== 'production') {
}
```

If you are building for latest browsers and don't transpile the "class" keyword use the "no-classes-transpile" dist:
```js
import React from 'react';

if (process.env.NODE_ENV !== 'production') {
const whyDidYouRender = require('@welldone-software/why-did-you-render/dist/no-classes-transpile/umd/whyDidYouRender.min.js');
whyDidYouRender(React);
}
```
Not doing so will [result in a bug](https://github.com/welldone-software/why-did-you-render/issues/5)
where a transpiled class tries to extend a native class:

`class constructors must be invoked with |new|`.


Then mark all the components you want to be notified about their re-renders with `whyDidYouRender` like so:

```js
Expand Down
3 changes: 2 additions & 1 deletion babel.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ module.exports = function(api){

const presets = [
['@babel/preset-env', {
modules: isTest ? 'commonjs' : false
modules: isTest ? 'commonjs' : false,
exclude: ['babel-plugin-transform-classes']
}],
'@babel/preset-react'
]
Expand Down
25 changes: 14 additions & 11 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
"main": "dist/cjs/whyDidYouRender.min.js",
"module": "dist/esm/whyDidYouRender.min.js",
"browser": "dist/umd/whyDidYouRender.min.js",
"main-no-classes-transpile": "dist/no-classes-transpile/cjs/whyDidYouRender.min.js",
"module-no-classes-transpile": "dist/no-classes-transpile/esm/whyDidYouRender.min.js",
"browser-no-classes-transpile": "dist/no-classes-transpile/umd/whyDidYouRender.min.js",
"files": [
"src",
"dist"
Expand All @@ -31,7 +34,7 @@
"cacheDirectory": ".temp/jest-cache"
},
"dependencies": {
"lodash": "^4.17.11"
"lodash": "^4.0.0"
},
"peerDependencies": {
"react": ">=16.0"
Expand All @@ -51,29 +54,29 @@
"concurrently": "^4.1.0",
"create-react-class": "^15.6.3",
"cross-env": "^5.2.0",
"eslint": "^5.10.0",
"eslint-plugin-jest": "^22.1.2",
"eslint-plugin-react": "^7.11.1",
"eslint": "^5.12.1",
"eslint-plugin-jest": "^22.1.3",
"eslint-plugin-react": "^7.12.4",
"eslint-watch": "^4.0.2",
"express": "^4.16.4",
"express-history-api-fallback": "^2.2.1",
"husky": "^1.3.0",
"husky": "^1.3.1",
"jest": "^23.6.0",
"jest-cli": "^23.6.0",
"magic-string": "^0.25.1",
"nollup": "^0.3.0",
"nollup": "^0.4.0",
"react": "^16.7.0",
"react-dom": "^16.7.0",
"react-hot-loader": "^4.6.3",
"react-test-renderer": "^16.7.0",
"rimraf": "^2.6.2",
"rollup": "^0.68.1",
"rollup-plugin-babel": "^4.1.0",
"rimraf": "^2.6.3",
"rollup": "^1.1.0",
"rollup-plugin-babel": "^4.3.1",
"rollup-plugin-commonjs": "^9.2.0",
"rollup-plugin-license": "^0.7.0",
"rollup-plugin-license": "^0.8.1",
"rollup-plugin-node-resolve": "^4.0.0",
"rollup-plugin-replace": "^2.1.0",
"rollup-plugin-terser": "^3.0.0"
"rollup-plugin-terser": "^4.0.2"
},
"authors": [
"Vitali Zaidman <vzaidman@gmail.com> (https://github.com/vzaidman)"
Expand Down
133 changes: 67 additions & 66 deletions rollup.config.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {flatMap} from 'lodash'
import {flatMap, compact} from 'lodash'
import resolve from 'rollup-plugin-node-resolve'
import commonjs from 'rollup-plugin-commonjs'
import babel from 'rollup-plugin-babel'
Expand All @@ -13,70 +13,71 @@ MIT Licensed
Generated by <%= pkg.authors[0] %>
Generated at <%= moment().format('YYYY-MM-DD') %>
`
export default flatMap(['none', 'shouldMinify', 'noClassesTranspile', 'both'], buildMode => {
const shouldMinify = buildMode === 'shouldMinify' || buildMode === 'both'
const shouldTranspileClasses = buildMode !== 'noClassesTranspile' || buildMode === 'both'

export default flatMap([false, true], shouldMinify => [
{
input: 'src/index.js',
output: {
name: 'whyDidYouRender',
file: pkg.browser.replace('.min', shouldMinify ? '.min' : ''),
format: 'umd',
sourcemap: shouldMinify,
sourcemapFile: pkg.browser.replace('.js', '.js.map')
},
plugins: [
babel({
exclude: 'node_modules/**'
}),
resolve(),
commonjs(),
shouldMinify && terser(),
license({
sourceMap: true,
banner
})
]
},
{
input: 'src/index.js',
output: [
// {file: pkg.module, format: 'es'}
// when https://github.com/TrySound/rollup-plugin-terser/issues/5 fixed
{
file: pkg.main.replace('.min', shouldMinify ? '.min' : ''),
format: 'cjs',
sourcemap: shouldMinify,
sourcemapFile: pkg.main.replace('.js', '.js.map')
}
],
plugins: [
babel({
exclude: 'node_modules/**'
}),
resolve(),
commonjs(),
shouldMinify && terser()
],
external: id => /lodash/.test(id)
},
{
input: 'src/index.js',
output: [
{
file: pkg.module.replace('.min', shouldMinify ? '.min' : ''),
format: 'esm',
const babelPlugins = compact([
shouldTranspileClasses && '@babel/plugin-transform-classes'
])

return [
{
input: 'src/index.js',
output: {
name: 'whyDidYouRender',
file: (shouldTranspileClasses ? pkg.browser : pkg['browser-no-classes-transpile'])
.replace('.min', shouldMinify ? '.min' : ''),
format: 'umd',
sourcemap: shouldMinify,
sourcemapFile: pkg.module.replace('.js', '.js.map')
}
],
plugins: [
babel({
exclude: 'node_modules/**'
}),
resolve(),
commonjs(),
shouldMinify && terser()
],
external: id => /lodash/.test(id)
}
])
sourcemapFile: pkg.browser.replace('.js', '.js.map')
},
plugins: [
babel({
exclude: 'node_modules/**',
plugins: babelPlugins
}),
resolve(),
commonjs(),
shouldMinify && terser(),
license({
sourcemap: true,
banner
})
]
},
{
input: 'src/index.js',
output: [
{
file: (shouldTranspileClasses ? pkg.main : pkg['main-no-classes-transpile'])
.replace('.min', shouldMinify ? '.min' : ''),
format: 'cjs',
sourcemap: shouldMinify,
sourcemapFile: pkg.main.replace('.js', '.js.map')
},
{
file: (shouldTranspileClasses ? pkg.module : pkg['module-no-classes-transpile'])
.replace('.min', shouldMinify ? '.min' : ''),
format: 'esm',
sourcemap: shouldMinify,
sourcemapFile: pkg.module.replace('.js', '.js.map')
}
],
plugins: [
babel({
exclude: 'node_modules/**',
plugins: babelPlugins
}),
resolve(),
commonjs(),
shouldMinify && terser(),
license({
sourcemap: true,
banner
})
],
external: id => /lodash/.test(id)
}
]
})