-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use expo-secure-store instead of Typeorm to store pings and answers data #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably need closer look at the snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
expo-secure-store
to store the pings and answers data as it provides simple supports for encryption whereas setting up encryption for Typeorm is very complicated.We stores each ping data (
Ping
) and each answer data (Answer
) as a individual keychain item. This is because keychain has a size limit (see https://docs.expo.io/versions/latest/sdk/securestore/), so it makes sense to store each element separately. We then store a list of ping IDs in a AsyncStorage item, and a list of answer IDs in a AsyncStorage item for each ping. An example looks like this:In AsyncStorage:
[wellbeingStream1, interactionStream1, wellbeingStream2]
wellbeingStream1
:[anxiety, stress, sadness]
interactionStream1
:[peerInteraction, familyInteraction]
wellbeingStream2
:[anxiety, stress, sadness]
In SecureStore: (all encrypted)
wellbeingStream1
:{ id: wellbeingStream1, notificationTime: ..., ... }
interactionStream1
:{ id: interactionStream1, notificationTime: ..., ... }
wellbeingStream1.anxiety
:{ pingId: wellbeingStream1, questionId: anxiety, data: ... }
wellbeingStream1.stress
:{ pingId: wellbeingStream1, questionId: stress, data: ... }
wellbeingStream1.sadness
:{ pingId: wellbeingStream1, questionId: sadness, data: ... }
interactionStream1.peerInteraction
:{ pingId: interactionStream1, questionId: peerInteraction, data: ... }
Changes:
PingEntity
andAnswerEntity
to zod'sPingSchema
andAnswerSchema
.@react-native-community/async-storage
and@react-native-community/slider
because of their better jest test support.SurveyScreen.test/
tests, we now actually test the stored answers data.Resolves #37.