Tighten up C source code scanning #408
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DemiMarie
force-pushed
the
fix-c-parsing
branch
from
ce4c440
to
5024583
Compare
* Parse C99/C++ line comments correctly * Error if trigraphs present and could affect compilation. * Reject invalid escaped newlines in many places * Reject escaped newlines in a comment start or end, or in a line comment.
|
The main motivation for this change is that many (if not most) tools (that are not compilers) mishandle these constructs, and this probably includes other implementations of Lex. |
DemiMarie
force-pushed
the
fix-c-parsing
branch
from
5024583
to
a6a3160
Compare
DemiMarie
force-pushed
the
fix-c-parsing
branch
from
a6a3160
to
a21781e
Compare
If the code is not actually C++, these need to be rejected (by a `#error`). This will be done later.
|
There's been a lot of activity which has produced conflicts. Could you rebase against master and resolve the conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comment.