Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "inner invoke" use "remove an event listener" #758

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make "inner invoke" use "remove an event listener" #758

wants to merge 2 commits into from

Conversation

oliverdunk
Copy link

@oliverdunk oliverdunk commented May 6, 2019 •
edited by pr-preview bot

My first PR!

A small clarification where inner invoke now uses the "remove an event listener" definition, instead of doing this in its own way.

Resolves #651

馃挜 Error: 500 Internal Server Error 馃挜

PR Preview failed to build. (Last tried on Jan 15, 2021, 7:33 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

馃毃 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

馃敆 Related URL

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>500 Internal Server Error</title>
</head><body>
<h1>Internal Server Error</h1>
<p>The server encountered an internal error or
misconfiguration and was unable to complete
your request.</p>
<p>Please contact the server administrator at 
 [no address given] to inform them of the time this error occurred,
 and the actions you performed just before this error.</p>
<p>More information about this error may be available
in the server error log.</p>
<hr>
<address>Apache/2.4.10 (Debian) Server at api.csswg.org Port 443</address>
</body></html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@annevk
Copy link
Member

annevk commented May 7, 2019

Thanks @oliverdunk! I saw your question on IRC about the participation agreement. The WHATWG Steering Group is trying to clarify this in whatwg/sg#67 and I'll ask them there about 1Password for you as it's not super clear to me. I'd assume not, but ...

@annevk annevk mentioned this pull request May 7, 2019
Closed
annevk
annevk reviewed May 7, 2019
View reviewed changes
dom.bs Outdated
<a for=list>remove</a> <var>listener</var> from <var>event</var>'s {{Event/currentTarget}}
attribute value's <a for=EventTarget>event listener list</a>.
<a>remove an event listener</a> with the <var>event</var>'s {{Event/currentTarget}}
and <var>listener</var></a>.
<!-- Do this before invocation to avoid reentrancy issues. No need to set removed to true since
each listener in listeners is run once anyway. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd reword the second sentence here to say something like "Note that there is no need to set removed to true since listener is run once, but it is done here to share an abstraction."

@oliverdunk
Copy link
Author

Thanks for the feedback @annevk! I'll try to update this soon, or at the very latest, when we're able to sort the legal situation.

Base automatically changed from master to main January 15, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make "inner invoke" use "remove an event listener"
2 participants
@oliverdunk @annevk