Editorial: use Infra list syntax in mutations #762
Conversation
As pointed out at #695 (review) it would be nice if this were more consistent.
| <li><p>If <var>node</var> is {{DocumentFragment}} <a>node</a>, then set <var>addedNodes</var> to | ||
| <var>node</var>'s <a>children</a>. | ||
|
|
||
| <li><p>Otherwise, if <var>node</var> is non-null, set <var>addedNodes</var> to « <var>node</var> ». |
There was a problem hiding this comment.
@domenic this is the only change that felt a little weird here due to it getting so much longer, but it's probably better?
There was a problem hiding this comment.
Yeah, this matches the code better. Nested ternaries are not great in either English or code, IMO. You could also use dl class="switch".
dom.bs
Outdated
| a {{DocumentFragment}} <a>node</a>, and a | ||
| list containing solely <var>node</var> otherwise. | ||
| <li><p>Let <var>nodes</var> be <var>node</var>'s <a>children</a>, if <var>node</var> is a | ||
| {{DocumentFragment}} <a>node</a>, « <var>node</var> » otherwise. |
There was a problem hiding this comment.
This reads really wrong; I'm not happy with where we've landed if this is what happens. Commas just don't work that way. Semicolon could work, or using a conjunction (either "and" or "or").
There was a problem hiding this comment.
Same if otherwise comes first? I see now I put them wrong way around. I guess I can do some follow-up on Monday in that original thread on this.
There was a problem hiding this comment.
Ah I see. If otherwise comes first it isn't as viscerally wrong, but I still have a slight preference for a conjunction or semicolon.
| <li><p>If <var>node</var> is {{DocumentFragment}} <a>node</a>, then set <var>addedNodes</var> to | ||
| <var>node</var>'s <a>children</a>. | ||
|
|
||
| <li><p>Otherwise, if <var>node</var> is non-null, set <var>addedNodes</var> to « <var>node</var> ». |
There was a problem hiding this comment.
Yeah, this matches the code better. Nested ternaries are not great in either English or code, IMO. You could also use dl class="switch".
As pointed out at #695 (review) it would be nice if this were more consistent.
Preview | Diff