Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align spec more closely with cache freshening #1041

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gterzian
Copy link
Member

@gterzian gterzian commented Jun 20, 2020

FIX #950

  • At least two implementers are interested (and none opposed):
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chrome: …
    • Firefox: …
    • Safari: …

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

@gterzian gterzian force-pushed the fix_cache_update branch 3 times, most recently from 77e6483 to f1298fe Compare June 20, 2020 07:45
@gterzian
Copy link
Member Author

gterzian commented Jun 20, 2020

@mnot I'm wondering if the test added in servo/servo#26999 would be testing for the correct behavior?

I'm actually not sure if the infra for http-cache test would be happy with that second fetch in case of a failing validation, might require some changes there too, but I'll first try to actually implement the logic to see what happens.

@gterzian
Copy link
Member Author

@annevk I think this is probably worth some implementation bugs, just to check that this behavior is indeed what others are doing?

I'm not sure about "implementer interest", I think this simply aligns fetch with the http-caching spec, and I wouldn't be surprised if this already matches what implementations are doing.

@annevk
Copy link
Member

annevk commented Jun 24, 2020

  1. It seems this allows for reducing the effective scope of storedResponse. We should probably make the text reflect that.
  2. And yeah, I think we should have some tests here to be sure. I also would not expect implementations to do a lot of this properly. E.g., combining of headers is one of the areas with known bugs (and perhaps some lack of clarity in the protocol as to which headers can be updated and such; see Updating stored headers httpwg/http-core#165).

Base automatically changed from master to main January 15, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Refreshing of stale response assumed to always be successful
2 participants