Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typo from null to path (whatwg#10053) #10105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chaburk
Copy link

@chaburk chaburk commented Jan 29, 2024

  • At least two implementers are interested (and none opposed):
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
    • Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): …
    • Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): …
  • MDN issue is filed: …
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)

fixed typo issue-whatwg#10053

@@ -65219,7 +65219,7 @@ try {
<p>The <dfn method for="CanvasDrawPath"><code
data-x="dom-context-2d-isPointInPath-path">isPointInPath(<var>path</var>, <var>x</var>,
<var>y</var>, <var>fillRule</var>)</code></dfn> method steps are to return the result of the
<span>is point in path steps</span> given <span>this</span>, null, <var>x</var>, <var>y</var>,
<span>is point in path steps</span> given <span>this</span>, path, <var>x</var>, <var>y</var>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want to put path inside <var>.

And then <var>y</var>, needs to be on a subsequent line.

@annevk
Copy link
Member

annevk commented Jan 29, 2024

Also, please make sure you can sign https://participate.whatwg.org/agreement.

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not edit any files in the review-drafts/ folder. Instead, only edit the source file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants