Wrap "activate view transition" with script prepare/clean up #10284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that we perform a microtask checkpoint (and set the incumbent script) right after resolving/rejecting the `ViewTransition` promises. It's necessary as those promises need to be resolved before the other rendering operations, mainly style/layout.
domenic
approved these changes
Apr 22, 2024
| <p>If <var>transition</var> is not null, then:</p> | ||
|
|
||
| <ol> | ||
| <li><p><span>Prepare to run script</span> given <var>document</var>.</p></li> |
There was a problem hiding this comment.
Newlines between <li>s, like elsewhere in the document
| <li><p><span>Clean up after running script</span> given <var>document</var>.</p></li> | ||
| </ol> | ||
|
|
||
| <p class=note>Activating a view transition might resolve/reject promises, so by wrapping the |
There was a problem hiding this comment.
Suggested change
| <p class=note>Activating a view transition might resolve/reject promises, so by wrapping the | |
| <p class="note">Activating a view transition might resolve/reject promises, so by wrapping the |
like elsewhere
|
Thanks. LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that we perform a microtask checkpoint (and set the incumbent script) right after resolving/rejecting the
ViewTransitionpromises.It's necessary as those promises need to be resolved before the other rendering operations, mainly style/layout.
(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )