Switch trusted types sinks to use union type #10286
Open
+148
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
annevk
reviewed
Apr 18, 2024
This replaces usages of HTMLString and ScriptURLString with their equivalent union types. The relevant algorithms are also updated to do the TT enforcement.
lukewarlow
force-pushed
the
tt-switch-union
branch
from
a786017
to
4196e61
Compare
annevk
reviewed
Apr 30, 2024
|
Pending w3c/trusted-types#510 I've removed the changes to document.write as chances are they'll need updating again. |
annevk
reviewed
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After recent discussions we've decided to change trusted types to use union IDL types across all sinks. This requires changes to the IDL and algorithms for the various sinks.
(See WHATWG Working Mode: Changes for more details.)
/dom.html ( diff )
/dynamic-markup-insertion.html ( diff )
/iframe-embed-object.html ( diff )
/infrastructure.html ( diff )
/workers.html ( diff )