-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hooks to inform WebDriver BiDi when a navigable is created or destroyed #10329
base: main
Are you sure you want to change the base?
Conversation
3627ab9
to
da8798b
Compare
da8798b
to
aab007e
Compare
I think this is broadly correct from a WebDriver point of view i.e. it looks like the WebDriver BiDi algorithms are invoked for the right kind of places (but I'm not sure I could tell if the exact point in the algorithms where they're called is correct). |
@foolip could you please take a look? |
Can you make sure the result builds before you request review? |
@domenic it has dependencies on WebDriver BiDi spec (that causes failures) that need to land first, but reviewers in the WebDriver BiDi spec would like to get a preliminary signal here first before landing changes there. Is there a way to suppress the errors to generate a preview without link? |
HTML does not automatically pick up links from other specs. You need to add them using https://github.com/whatwg/wattsi/blob/main/Syntax.md#cross-specification-cross-references . That will fix the build error. |
@domenic thanks, the preview is fixed now! (I have no permissions to run the build step) |
Currently, WebDriver BiDi spec patches the HTML spec to define when WebDriver BiDi algorithms take place. This PR updates the HTML spec to explicitly invoke WebDriver BiDI algorithms. Note that WebDriver BiDi spec is still not up-to-date w.r.t the use of browsing context vs navigable and current browsing context mentions actually have to be navigables in most cases.
Corresponding WebDriver BiDi change: w3c/webdriver-bidi#708
Closes #6194
/document-sequences.html ( diff )
/infrastructure.html ( diff )