Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hooks to inform WebDriver BiDi when a navigable is created or destroyed #10329

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

OrKoN
Copy link

@OrKoN OrKoN commented May 7, 2024

Currently, WebDriver BiDi spec patches the HTML spec to define when WebDriver BiDi algorithms take place. This PR updates the HTML spec to explicitly invoke WebDriver BiDI algorithms. Note that WebDriver BiDi spec is still not up-to-date w.r.t the use of browsing context vs navigable and current browsing context mentions actually have to be navigables in most cases.

Corresponding WebDriver BiDi change: w3c/webdriver-bidi#708

Closes #6194


/document-sequences.html ( diff )
/infrastructure.html ( diff )

@OrKoN OrKoN force-pushed the orkon/webdriver-navigable-hooks branch from 3627ab9 to da8798b Compare May 8, 2024 09:27
@OrKoN OrKoN changed the title Add hooks to inform WebDriver BiDi when a navigable is created Add hooks to inform WebDriver BiDi when a navigable is created or destroyed May 8, 2024
@OrKoN OrKoN force-pushed the orkon/webdriver-navigable-hooks branch from da8798b to aab007e Compare May 13, 2024 08:57
@OrKoN OrKoN marked this pull request as ready for review May 22, 2024 09:20
@jgraham
Copy link
Member

jgraham commented May 22, 2024

I think this is broadly correct from a WebDriver point of view i.e. it looks like the WebDriver BiDi algorithms are invoked for the right kind of places (but I'm not sure I could tell if the exact point in the algorithms where they're called is correct).

@OrKoN
Copy link
Author

OrKoN commented May 22, 2024

@foolip could you please take a look?

@domenic
Copy link
Member

domenic commented May 22, 2024

Can you make sure the result builds before you request review?

@OrKoN
Copy link
Author

OrKoN commented May 22, 2024

@domenic it has dependencies on WebDriver BiDi spec (that causes failures) that need to land first, but reviewers in the WebDriver BiDi spec would like to get a preliminary signal here first before landing changes there. Is there a way to suppress the errors to generate a preview without link?

@domenic
Copy link
Member

domenic commented May 23, 2024

HTML does not automatically pick up links from other specs. You need to add them using https://github.com/whatwg/wattsi/blob/main/Syntax.md#cross-specification-cross-references . That will fix the build error.

@OrKoN
Copy link
Author

OrKoN commented May 23, 2024

@domenic thanks, the preview is fixed now! (I have no permissions to run the build step)

@OrKoN
Copy link
Author

OrKoN commented May 29, 2024

@domenic @foolip could you provide any feedback on this PR or suggest who might be a good reviewer for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Hooks for changes to the tree of browsing contexts
3 participants