Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mutability check from legacy activation behaviors #5827

Merged
merged 2 commits into from Aug 17, 2020

Conversation

saschanaz
Copy link
Member

@saschanaz saschanaz commented Aug 14, 2020

Followup from #5805.

(See WHATWG Working Mode: Changes for more details.)

cc @domenic


/input.html ( diff )

@saschanaz saschanaz changed the title Remove mutability check from legacy-pre-activation behavior Remove mutability check from legacy activation behaviors Aug 14, 2020
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

Would you mind fixing minor editorial issues with the previous PR that I missed?

and is not in Checkbox nor Radio, then return

should be

and is not in the Checkbox state and is not in the Radio state, then return.

domenic pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 17, 2020
@domenic domenic merged commit 3729254 into whatwg:master Aug 17, 2020
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Aug 25, 2020
…s, a=testonly

Automatic update from web-platform-tests
Add tests for legacy-activation-behaviors

Corresponds to whatwg/html#5827.
--

wpt-commits: a7a7d482821337441dd86d508f8664b1c0a87146
wpt-pr: 25020
ambroff pushed a commit to ambroff/gecko that referenced this pull request Nov 4, 2020
…s, a=testonly

Automatic update from web-platform-tests
Add tests for legacy-activation-behaviors

Corresponds to whatwg/html#5827.
--

wpt-commits: a7a7d482821337441dd86d508f8664b1c0a87146
wpt-pr: 25020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants