Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import assertions integration #5883

Closed

Commits on Jun 19, 2020

  1. Reland JSON modules

    Reland JSON modules by reverting a530f6f,
    resolving merge conflicts, and updating the change with respect to the
    string changes in a9ef15d.
    dandclark committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    914e7d5 View commit details
    Browse the repository at this point in the history
  2. Add import attribute type checks and initial plumbing.

    Update all [[RequestedModules]] references to reflect the change from string to ModuleRequest.
    Pass ModuleRequest instead of url to 'internal module graph fetching procedure'.
    Add optional ModuleRequest param to 'fetch a single module script'.
    Add checks in 'fetch a single module script' to fail if the type doesn't match.
    dandclark committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    b058240 View commit details
    Browse the repository at this point in the history
  3. Plumb through ModuleRequest instead of string for 'fetch an import() …

    …module script graph', HostResolveImportedModule, and HostResolveImportedModuleDynamically.
    dandclark committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    d0137f5 View commit details
    Browse the repository at this point in the history
  4. Don't cache a null entry in the module map in the case where the MIME…

    … type is valid but doesn't match the requested type.
    dandclark committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    b2e7065 View commit details
    Browse the repository at this point in the history
  5. Allow modulepreload to work for all module types without needing to s…

    …pecify type at the point of preload. Achieve this by adding 'module type must match' flag to 'fetch a single module script', which is unset only in the case of modulepreload.
    dandclark committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    0cbf597 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6932074 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. Configuration menu
    Copy the full SHA
    1f83c7e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a3621dd View commit details
    Browse the repository at this point in the history
  3. Revert added null check in 'fetch a modulepreload module script graph…

    …'; I'll add this in a separate PR.
    dandclark committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    55ebd12 View commit details
    Browse the repository at this point in the history
  4. Reference ParseJSONModule from import-attributes proposal instead of …

    …defining steps in HTML spec
    dandclark committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    af41b28 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. Cache an entry in the module map if the fetched module was valid but …

    …does not match the type specified at the import site.
    dandclark committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    a2d4260 View commit details
    Browse the repository at this point in the history
  2. Extend note to be clear that the module must have no effect until a r…

    …equest matches its type and it is evalutated
    dandclark committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    f79c01f View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. When a valid MIME type is received that doesn't match the requested t…

    …ype, cache the fetch response instead of creating and caching the module script. The module script is created only when there is a type match. This addreses concerns that parsing modules (perhaps even types of modules that don't yet exist) could have side-effects.
    dandclark committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    7c900a1 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2020

  1. Wrap <p class=note> in <li> so it's not directly under an <ol>, which…

    … the Travis CI build doesn't like.
    dandclark committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    55c9ed9 View commit details
    Browse the repository at this point in the history
  2. Whitespace change: remove double spaces after sentences in notes. Hop…

    …efully unstick CI build, which seems to be stuck.
    dandclark committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    322808d View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2020

  1. Merge branch 'upstream-master' into dandclark/import-attributes

    Resolve many merge conflicts in /source.
    dandclark committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    43e6fe3 View commit details
    Browse the repository at this point in the history
  2. Reword invocations of 'create a module script with matching type' to …

    …ensure they are synchronous with respect to the calling 'fetch a single module script'
    dandclark committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    9f2ae27 View commit details
    Browse the repository at this point in the history
  3. Change 'fetch a single module script' to fail if there are any unreco…

    …gnized import attributes, and assert that there is only one of key 'type' (which should be guaranteed by Ecma262)
    dandclark committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    e86dd65 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. Instead of passing fetch response parameter to 'create a module scrip…

    …t with matching type', retrieve it from the module map within the algorithm.
    dandclark committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    3318ed3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3c0dce2 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Reword caching comment

    dandclark committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    1c9df5a View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2020

  1. Configuration menu
    Copy the full SHA
    3247e99 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2020

  1. Update for the latest rename of the proposal from 'Import Conditions'…

    … to 'Import Assertions'
    dandclark committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    dca376b View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2020

  1. Use module type as part of module map cache key instead of caching re…

    …sponse body in the case of a failed type check.
    dandclark committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    e3359b5 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. Configuration menu
    Copy the full SHA
    0857ec8 View commit details
    Browse the repository at this point in the history
  2. Change 'abort these steps' to 'return' to match recent changes in 'fe…

    …tch a single module script'.
    dandclark committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    aafb256 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. Remove JSON modules references, switch JavaScript module script refer…

    …ences back to just 'module script'
    dandclark committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    9164acf View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. Configuration menu
    Copy the full SHA
    f53c203 View commit details
    Browse the repository at this point in the history
  2. Update module map dfn note to explain purpose of having module type i…

    …n key, and that in practice fetches and module evalutations will only occur once per specifier
    dandclark committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    73f2be2 View commit details
    Browse the repository at this point in the history
  3. Ignore unknown import assertions instead of failing. Continue failing…

    … for unrecognized types (which is to say, any type at all).
    dandclark committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    6ed4474 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. Configuration menu
    Copy the full SHA
    c225d56 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. Configuration menu
    Copy the full SHA
    1566bc0 View commit details
    Browse the repository at this point in the history
  2. Review feedback: use tuple instead of pair, improve module map defini…

    …tion, use 'javascript' instead of undefined, fix indents.
    dandclark committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    3c94b31 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2020

  1. Review feedback: Link to memory cache issue, null --> 'javascript' ty…

    …pe, misc whitespace issues.
    dandclark committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    9da92b5 View commit details
    Browse the repository at this point in the history
  2. Remove duplicated words

    dandclark committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    26c2b81 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2020

  1. Configuration menu
    Copy the full SHA
    4ad7d2d View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2020

  1. Configuration menu
    Copy the full SHA
    614a9f4 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2020

  1. Configuration menu
    Copy the full SHA
    2fc3616 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. Configuration menu
    Copy the full SHA
    697a6f1 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2020

  1. Configuration menu
    Copy the full SHA
    a9eed9b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    973ec71 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2020

  1. Clarify that memory cache mitigating violation of import assertions s…

    …pec recommendation is not a sure thing.
    dandclark committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    fdc08f8 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. Configuration menu
    Copy the full SHA
    30e27fb View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. Configuration menu
    Copy the full SHA
    9ec7c7e View commit details
    Browse the repository at this point in the history