accessibility popover guidance #9024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this PR is replacing whatwg#8791 due to the changes to the related popovertarget attributes. i've added more examples and incorporated feedback that was provided from the review of the original PR.
scottaohara
added
accessibility
remove 'recommended' from note
fix typo in closing tag order
add missing id to sub-navigation popover example. one last example showing how to use popover=manual to reveal a popover as a status message (e.g., a toast).
|
I had been asked in an offline conversation if i could get a status message / toast-like example into the spec for popover=manual. Hence the most recent example added. If anyone thinks this is adding too much, or if more details are necessary to accompany this example, please let me know. |
josepharhar
reviewed
Mar 14, 2023
josepharhar
reviewed
Mar 14, 2023
mfreed7
approved these changes
Mar 15, 2023
fix incorrect attribute, re catch from @mfreed7
resolves feedback from @josepharhar
|
thank you @josepharhar @mfreed7. changes have been pushed |
after speaking with @aleventhal, a note about popovers/live regions has been added after the code examples.
annevk
reviewed
Mar 17, 2023
There was a problem hiding this comment.
Thanks @scottaohara! I've got mainly nits, one more substantive comment.
this addresses the feedback from @annevk's review.
|
thank you @annevk. have incorporated your feedback |
annevk
reviewed
Mar 17, 2023
|
Thanks @scottaohara. I plan on merging this Monday. If there's any remaining nits at that point I'll attempt to fix them. |
annevk
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is replacing #8791 due to the changes to the related popovertarget attributes. Was much easier to start a new PR than resolve the diffs.
i've added more examples and incorporated feedback that was provided from the review of the original PR.
added the labels and reviewers from the original PR.
Thanks!
/popover.html ( diff )