Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the processing model for dns-prefetch #9029

Merged
merged 4 commits into from
Mar 16, 2023
Merged

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Mar 15, 2023

Uses the exported "resolve an origin" from Fetch.

Note that this still doesn't include the CSP bits, which are also not implemented anywhere for this & preconnect.

Closes #9015

(See WHATWG Working Mode: Changes for more details.)


/infrastructure.html ( diff )
/links.html ( diff )

Uses the exported "resolve an origin" from Fetch.

Note that this still doesn't include the CSP bits,
which are also not implemented anywhere for this &
preconnect.

Closes whatwg#9015
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after one fix.

I assume this is pretty much untestable, at least at this point. (Maybe if WPT had its own DNS server??)

Can you fill in the implementation status?

source Show resolved Hide resolved
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will give a day or so for anyone else to comment, in particular @annevk might be interested because of the Fetch integration.

I'm overall really happy with how quickly you bang out pieces of specification that have been missing for many years :)

source Outdated
Comment on lines 25800 to 25801
<p class="note">This returned IP address is obtained but not used directly. It will be cached
for subsequent use.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems slightly incorrect. I would suggest something like:

As the results of this algorithm can be cached, future fetches could be faster.

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great modulo nit. I was thinking we might need obtaining the partition key to move to Fetch, but it doesn't seem like a big deal. We can do that if we ever need a bigger refactoring.

@noamr
Copy link
Contributor Author

noamr commented Mar 16, 2023

Looks great modulo nit. I was thinking we might need obtaining the partition key to move to Fetch, but it doesn't seem like a big deal. We can do that if we ever need a bigger refactoring.

Fixed. We can think of refactoring it into fetch in the next patch (using prefetch-diractive CSP for dns-prefetch and preconnect)

@annevk annevk merged commit 16c7464 into whatwg:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Specify processing model for dns-prefetch
3 participants