Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize and correct <dialog> show() and showModal() #9039

Merged
merged 2 commits into from
Mar 19, 2023
Merged

Modernize and correct <dialog> show() and showModal() #9039

merged 2 commits into from
Mar 19, 2023

Conversation

annevk
Copy link
Member

@annevk annevk commented Mar 16, 2023 •
edited by pr-preview bot

I did this in particular because of some popover copypasta giving show() a variable it doesn't know anything about.

/interactive-elements.html ( diff )

@annevk annevk added topic: dialog The <dialog> element. topic: popover The popover attribute and friends labels Mar 16, 2023
domenic
domenic approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one fix

source Show resolved Hide resolved
@annevk annevk merged commit aed86a0 into main Mar 19, 2023
@annevk annevk deleted the annevk/dialog-show branch March 19, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
topic: dialog The <dialog> element. topic: popover The popover attribute and friends
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@annevk @domenic