Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading example (Issue 8366) #9078

Merged
merged 4 commits into from
Mar 29, 2023
Merged

Heading example (Issue 8366) #9078

merged 4 commits into from
Mar 29, 2023

Conversation

JAWS-test
Copy link
Contributor

@JAWS-test JAWS-test commented Mar 27, 2023

Each heading following another heading lead in the outline must have a heading level that is less than, equal to, or 1 greater than lead's heading level.

The example after this sentence does not fit the sentence (see #8366). That is why I have adjusted the example.


/sections.html ( diff )

@domenic
Copy link
Member

domenic commented Mar 27, 2023

This is incorrect; 2 < 4 so the example fits without changes.

@domenic domenic closed this Mar 27, 2023
@JAWS-test
Copy link
Contributor Author

JAWS-test commented Mar 28, 2023

@domenic According to the HTML specification, an H4 heading may be followed by an H2 heading, so the current example is logically incorrect, but semantically correct. In my example, an H1 is followed by an H3, which would be logically halfway correct, but semantically wrong, because an H2 would have to be used instead of the H3. I ask not to close my PR, but to merge it.

See your own comment.

@domenic
Copy link
Member

domenic commented Mar 28, 2023

I don't understand how you're using the words "logically" or "semantically". The specification is clear on what the expected semantics are.

My comment does not contradict the fact that the current specification's example is correct. (Whether it's logically or semantically correct, I don't know, but it's correct according to the specification.)

@JAWS-test
Copy link
Contributor Author

@domenic

My comment does not contradict the fact that the current specification's example is correct.

That is exactly the problem. The current example is correct, but the sentence above it says: "The following example is non-conforming". I have thus turned the conforming example into a non-conforming example

@domenic
Copy link
Member

domenic commented Mar 28, 2023

I'm so sorry. I missed that context. I think the words "correct" and "incorrect" can be confusing when used to discuss how correct/incorrect a non-conforming example is.

@domenic domenic reopened this Mar 28, 2023
@JAWS-test
Copy link
Contributor Author

I don't understand how you're using the words "logically" or "semantically".

  • logically: Heading structure according to the content of the heading (Apples should be parent to Taste because Taste is a property of Apples).
  • semantically: Heading structure according to the level of headings (numbers 1 to 6)

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good, and apologies again for me being confused. Let me know when you or your company has signed the Participant Agreement and we can merge.

@JAWS-test
Copy link
Contributor Author

@domenic Thank you very much. I have signed the Participant Agreement

@domenic
Copy link
Member

domenic commented Mar 28, 2023

Hi @JAWS-test, can you confirm that https://github.com/whatwg/participant-data/blob/main/individuals.json#L4500 is the full name you use to sign legal documents with?

@JAWS-test
Copy link
Contributor Author

@domenic I sign with the family name. If you need my full name: see my email address, which I have also entered in the form.

@domenic
Copy link
Member

domenic commented Mar 29, 2023

Thanks. We need the name you use to sign legal contracts with, which for most people includes their full name. Can you please edit the file I pointed to above (using the GitHub edit UI to send a PR is fine) to fix the signature? As a matter of process, I cannot edit your signature for you.

@JAWS-test
Copy link
Contributor Author

@domenic I added my first name

domenic pushed a commit to whatwg/participant-data that referenced this pull request Mar 29, 2023
@domenic domenic merged commit 2368dfe into whatwg:main Mar 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants