Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify #named-access-on-the-window-object #9080

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

delan
Copy link
Contributor

@delan delan commented Mar 28, 2023

This patch clarifies #named-access-on-the-window-object per #9068 by:

  • adding a note that reads “Since the Window interface has the [Global] extended attribute, its named properties follow the rules for named properties objects rather than legacy platform objects.”
  • in the IDL for #window, reordering the lines near the named getter to make the comment easier to notice
  • elaborating on the note that reads “There will be at least one such object, by definition.” because it wasn’t clear how this was the case or which definition guaranteed that (at least without reading the source)
  • elaborating on the similar note in #dom-document-nameditem for the same reason

/dom.html ( diff )
/infrastructure.html ( diff )
/nav-history-apis.html ( diff )

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with some typographical fixes

source Show resolved Hide resolved
source Show resolved Hide resolved
@delan delan requested a review from domenic March 29, 2023 03:19
@domenic domenic merged commit abf8fae into whatwg:main Mar 29, 2023
1 check passed
@delan delan deleted the window-named-access branch March 29, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants