Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add invokers (invoketarget & invokeaction) #9841

Open
wants to merge 69 commits into
base: main
Choose a base branch
from
+519 −22
Open

Add invokers (invoketarget & invokeaction) #9841

Changes from 63 commits
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
c1c34a1
Add InvokeElement, InvokeEvent, steps for invocation
keithamus Oct 5, 2023
e06b509
Add popover default behavior for invoke targets
keithamus Oct 22, 2023
5332696
Add dialog associated invocation action algorithm
keithamus Feb 13, 2024
53ca0af
Add non-normative reference table for invoke actions
keithamus Feb 13, 2024
3fa0df4
fix punctuation
keithamus Feb 13, 2024
0641590
add note on invoketarget taking precedence over popovertarget
keithamus Feb 13, 2024
c099437
reword non-normative sections
keithamus Feb 13, 2024
b6de0d8
fix punctuation
keithamus Feb 13, 2024
c942d37
allow null actions
keithamus Feb 13, 2024
c1d0578
rename notCancelled to continue
keithamus Feb 13, 2024
4cefcf4
remove extra </li>
keithamus Feb 13, 2024
e03d894
move </li>
keithamus Feb 13, 2024
74eabd9
s/follwoing/following
keithamus Feb 13, 2024
d71aa2c
fix wording in table for popover show/hide
keithamus Feb 13, 2024
fa0b8dd
fix typo
keithamus Feb 13, 2024
42c2c3d
move to using an enumerated attribute
keithamus Feb 26, 2024
8dfcbc5
check popover validity in popover invoke case
keithamus Mar 12, 2024
b40ba86
dont dispatch Invoke events for custom actions without a -
keithamus Mar 12, 2024
8eb6c3c
fix wonky tag
keithamus Mar 12, 2024
7ce17a7
ensure event is not fired for valid actions on invalid elements
keithamus Mar 16, 2024
cfcda15
remove extraneous closing tags
keithamus Mar 16, 2024
89bd8c8
fix missing closing tag
keithamus Mar 16, 2024
015f935
fix nested <ol>
keithamus Mar 16, 2024
910e232
camelCase vars
keithamus Mar 18, 2024
ed07121
add missing period
keithamus Mar 21, 2024
43f7a9e
drop erroneous plural
keithamus Mar 21, 2024
8dca0ab
reword invokeaction setting to mention it must have a dash
keithamus Mar 21, 2024
6ffe325
address review commentary
keithamus Apr 9, 2024
c6bca61
fixup attr-associated element steps
keithamus Apr 22, 2024
d0da230
drop whitespace lines
keithamus Apr 22, 2024
8271024
Merge remote-tracking branch 'upstream/main' into add-invoke
keithamus Apr 22, 2024
8b2d5ef
fixup attr-associated element steps again
keithamus Apr 22, 2024
4ad74f1
fixup button invoke steps
keithamus Apr 22, 2024
d11e9a8
add invokeaction/invoketarget attributes to indices
keithamus May 3, 2024
57a2ec4
refine the button invoke/popover steps
keithamus May 3, 2024
053eea6
s/show as modal/show modal dialog/
keithamus May 3, 2024
0ae49ba
s/this/subject/ in show modal dialog
keithamus May 3, 2024
2013e27
various gramatical punctuation fixes
keithamus May 3, 2024
deadc6d
s/this/subject/ in dialog invoke action steps
keithamus May 3, 2024
3a6b40b
drop invokee argument from is valid invoke action steps
keithamus May 3, 2024
02d1cc0
pass invoker to invocation action steps
keithamus May 3, 2024
4dd6cbc
use correct button value concept for dialog invocation action steps
keithamus May 3, 2024
3b933bc
drop early returns in dialog invocation action steps
keithamus May 3, 2024
d6a49a0
simplify web developer prose
keithamus May 3, 2024
5baf467
fix wonky grammar in InvokeEvent action
keithamus May 3, 2024
93e12cc
use span not code for retargeting concept
keithamus May 3, 2024
5231e73
use InvokeEvent constructor in invoketarget attribute activation beha…
keithamus May 3, 2024
d845085
reword non-normative sections
keithamus May 3, 2024
8f2f147
Add more non-normative text about invokeaction defaults and missing i…
keithamus May 3, 2024
d56ea6a
link to popover/dialogs in invokeaction attribute enumerations
keithamus May 3, 2024
0c6a899
use InvokerElement mixin!
keithamus May 3, 2024
a72df39
various gramatical punctuation fixes
keithamus May 3, 2024
7e164d6
remove uneccessary (and broken) nesting
keithamus May 3, 2024
a38016e
refactor Node to be Element in invoke target attribute activation beh…
keithamus May 3, 2024
6de6013
fixup no-state check in attribute activation behavior
keithamus May 3, 2024
daefd79
add assert
keithamus May 3, 2024
e2eef3f
s/set/initialized
keithamus May 3, 2024
7631962
avoid indenting a whole block, use early return instead
keithamus May 3, 2024
1560ba7
s/popover/invokee
keithamus May 3, 2024
48c5376
Compact some let statements
keithamus May 3, 2024
8b6a3c4
combine the two comments around HTML element having specific invoker …
keithamus May 3, 2024
fa2a481
s/invokee/element
keithamus May 3, 2024
546167a
reword invokeevent description
keithamus May 3, 2024
49cf0ad
drop redundant element check on element
keithamus May 8, 2024
1e3795b
s/node/element
keithamus May 8, 2024
2a45f6c
fix formatting, add missing "attribute"
keithamus May 8, 2024
b13df14
capitalize sentence
keithamus May 8, 2024
9a5ab06
add assert
keithamus May 8, 2024
2dd96e2
Merge remote-tracking branch 'upstream/main' into add-invoke
keithamus May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view