Meta: Add Node.js bug link to PR template #525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the discussion in nodejs/node#33315, Node.js would like to have bugs filed whenever there is a normative spec change. Make sure this is done by adding an item to the PR template.
|
We need to make this change in https://github.com/whatwg/spec-factory and probably scope it to URL. Otherwise whenever we make a change to this template we'd end up reverting this. |
This was referenced Aug 23, 2020
|
This got fixed in #684. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion in nodejs/node#33315,
Node.js would like to have bugs filed whenever there is a normative spec
change. Make sure this is done by adding an item to the PR template.
(See WHATWG Working Mode: Changes for more details.)