Adds signal socket noop keepalive #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves/commits the
brokenSignalDetectorOnexperiment previously running in PWA to jslib-media. It has been rolled out 100% for 1.5 months on PWA. It is used for faster client side disconnect detection, with a nice side effect of preventing most of the 5m periodic disconnectsA small change here is to turn on/off the noop keepalive loop when disconnected. And only apply it when using websockets (which we always do, but in case that changes...)
See also:
https://github.com/whereby/pwa/pull/3860
https://linear.app/whereby/issue/COB-187/decide-how-to-move-brokensignaldetectoron-from-experiment-to-feature
socketio/socket.io#4868
📦 Published PR as canary version:
1.5.3--canary.41.7017285072.0✨ Test out this PR locally via:
npm install @whereby/jslib-media@1.5.3--canary.41.7017285072.0 # or yarn add @whereby/jslib-media@1.5.3--canary.41.7017285072.0