Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detached route creation #587

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Detached route creation #587

wants to merge 6 commits into from

Conversation

wheresrhys
Copy link
Owner

TODO

  • Tests that methods behave basically the same as existing methods
  • Test that inspection based on passing in routes basically works
  • Deprecate (with warning) use of route name
  • Document in the midst of existing docs
  • New docs page outlining the new approach

wheresrhys
wheresrhys commented Aug 16, 2020
View reviewed changes
src/Route/index.js Outdated Show resolved Hide resolved
@wheresrhys
Merge branch 'master' of https://github.com/wheresrhys/fetch-mock int…
85724d8 
…o detached-route-creation

* 'master' of https://github.com/wheresrhys/fetch-mock: (29 commits)
  browsers again
  aaargh - lint!
  fix a test that should've always failed reallyI guess node 15 is stricter about some things
  revert to old browsers docker image
  correct browser docker image name
  babel config file name chamnge
  hopefully fix all failnig jobs
  install browsers
  use lts and current aliases for images
  fix some docker image names
  fix invalid circleci config
  remove babelifying from karma testsbrowsers are good enough nowadays
  update node versions tested on
  reference new bable plugins from karam config
  setup babel correctly
  stop relying on transform runtime plugin in node6 test
  install babel core
  upgrade babel
  fixed type errors in a way which is looser, but definitely backwasrd compatible
  update Promise type to use new PromiseLike type
  ...
@wheresrhys
fix linting;
b6caf96
@wheresrhys
removed compileRoute method from FetchMo0ck clas
9e8e8d8
@wheresrhys
avoid passing arrays around
bb89087
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@wheresrhys