Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-fetch quick-fix #623

Closed
wants to merge 1 commit into from
Closed

node-fetch quick-fix #623

wants to merge 1 commit into from

Conversation

oliverturner
Copy link

@oliverturner oliverturner commented Jan 6, 2022

This PR specifies the same version of node-fetch for both peer and dev dependencies, providing temporary respite from node-fetch@3 going full ESM

This is a temporary workaround in advance of an update like Esm for realz addressing the issue concretely

Unrelated changes

  • Updated karma-webpack to fix incompatibility between its webpack dependency and the package-specified version
  • CI was failing because of linting errors that weren't reproducible locally. Updating eslint + plugins and turning off errors for code that wasn't previously considered infringing was a stop-gap measure. The majority of the changes to files are formatting updates resulting from running eslint with the --fix flag.

The final coveralls-related error may be something to do with a Github token per this comment

Update karma-webpack in line with webpack version
Update linting infra and ignore new infractions
@oliverturner oliverturner deleted the pin-node-fetch branch March 12, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant