Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curl c ommand #16

Merged
merged 5 commits into from Dec 12, 2018
Merged

Curl c ommand #16

merged 5 commits into from Dec 12, 2018

Conversation

dannycochran
Copy link
Collaborator

Our curl command can result in a thrown exception:

request/request#2120

So we need to encode it, and it's the responsibility of the client to decode.

whichsteveyp
whichsteveyp reviewed Dec 12, 2018
View reviewed changes
Copy link
Owner

@whichsteveyp whichsteveyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these looks good to me! Does MAX_HEADER_SIZE always need to be 40KB or should it be conditional if shouldAddCurlheader is present? Are we assessing the existing header size before adding the curl or making sure adding it wouldn't exceed the limit?

whichsteveyp
whichsteveyp requested changes Dec 12, 2018
View reviewed changes
Copy link
Owner

@whichsteveyp whichsteveyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also could we ensure this is in the README / documentation (do we have any?)

@dannycochran dannycochran merged commit baece5f into master Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whichsteveyp whichsteveyp whichsteveyp requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dannycochran @whichsteveyp