Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix headless rendering with latest chrome #361

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix headless rendering with latest chrome #361

wants to merge 2 commits into from

Conversation

rafique
Copy link

@rafique rafique commented Jan 2, 2021

No description provided.

maartenbreddels
maartenbreddels requested changes Jan 4, 2021
View reviewed changes
Copy link
Collaborator

@maartenbreddels maartenbreddels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

thanks for this! I have a few comments, hope you can address them.

Regards,

Maarten

ipyvolume/headless.py Outdated Show resolved Hide resolved
ipyvolume/headless.py Outdated Show resolved Hide resolved
ipyvolume/headless.py
try:
url = result['result']['result']['value']
url = result[0]['result']['result']['value']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did this change, and which version, and can we make it detect this? so it also works on older versions?

Copy link
Author

@rafique rafique Jan 5, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I don't know why/when this has changed. This seems to work fine but recently throwing the following error: "tuple indices must be integers or slices, not str". This is the main reason prompting this pull request. Since there has been no recent update to ipyvolume python module, my guess is that something else (chrome/ipyvolume js module/threejs) has been updated

ipyvolume/headless.py Outdated Show resolved Hide resolved
ipyvolume/headless.py Show resolved Hide resolved
ipyvolume/headless.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maartenbreddels maartenbreddels maartenbreddels requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rafique @maartenbreddels