build, icons: Optimize raw file SVGO config further and re-crush icons

Adding further options to general SVGO config including
- new `eol: 'lf'` and
- new `finalNewline: true`
both additions of recent minor SVGO versions. With that deleting the
command line `final-newline` flag.

With comment https://gerrit.wikimedia.org/r/c/design/codex/+/755319/comment/35fbaf55_19418aac/
pointing to svg/svgo#1353 the few added bytes
seem acceptable for better usage of the libraries raw icons. Also in a
far-future we might include Codex icon package raw SVGs as the general
WikimediaUI icon library instead of currently OOUI – exposing them to a
much wider audience. With that people opening those icons in Inkscape
or similar will only become more common.

Therefore re-crushing SVGs with new SVGO config and
adding 'minify:svg' script to 'build:svg'.

Bug: T299738
Change-Id: Ib1b97c793a1c41cde26a83932dca9f64bf67a4a9

packages/icons/.svgo.config.js

@@ -5,7 +5,6 @@
  * https://www.mediawiki.org/wiki/Manual:Coding_conventions/SVG#Exemplified_safe_configuration
  */
 module.exports = {
-	multipass: true,
 	plugins: [
 		{
 			// Set of built-in plugins enabled by default.
@@ -29,13 +28,12 @@ module.exports = {
 		'sortAttrs',
 	],
 	// Configure the indent (default 4 spaces) used by `--pretty` here:
-	// @see https://github.com/svg/svgo/blob/master/lib/svgo/js2svg.js#L6 for more config options
-	//
-	// Unfortunately EOL cannot be configured, SVGO uses the platform's EOL marker.
-	// On non-unix systems the linebreaks will be normalized to LF (unix) only at git commit,
-	// assuming `core.autocrlf` is 'true' (default) or 'input'.
+	// @see https://github.com/svg/svgo/blob/main/lib/svgo/coa.js#L194 for more config options
 	js2svg: {
-		indent: "\t",
+		eol: 'lf',
+		finalNewline: true,
+		indent: '\t',
 		pretty: true,
-	}
+	},
+	multipass: true
 }

packages/icons/package.json

@@ -23,11 +23,11 @@
 		"build": "npm run build:vite && npm run build:json && npm run build:svg && npm run test:unit -- tests/outputTypes.test.ts --coverage=false",
 		"build:vite": "vite build",
 		"build:json": "node ./buildIconsJson.js",
-		"build:svg": "cp -a src/images dist/",
+		"build:svg": "npm run minify:svg && cp -a src/images dist/",
 		"build-if-missing": "test -e dist/codex-icons.json || npm run build",
 		"lint": "npm run lint:ts",
 		"lint:ts": "tsc --noEmit --emitDeclarationOnly false",
-		"minify:svg": "svgo --config=.svgo.config.js --quiet --recursive --folder ./src/images --final-newline",
+		"minify:svg": "svgo --config=.svgo.config.js --quiet --recursive --folder ./src/images",
 		"test": "npm run lint && npm run test:unit",
 		"test:unit": "jest -c .jest/jest.config.json"
 	},