Update jsdoc plugin #307
Merged
Update jsdoc plugin #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v29.1.3 of the jsdoc plugin fixes an issue when using the require-param rule (part of plugin:jsdoc/recommended) in --fix mode.
|
In the release notes it says "Removes JSDuck support (unions with "/" instead of "|")" - I assume that means that in JSDuck you could use "/" instead of "|", which we never did anyway. |
edg2s
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v29.1.3 of the jsdoc plugin fixes an issue when using the require-param rule (part of plugin:jsdoc/recommended) in --fix mode (gajus/eslint-plugin-jsdoc#607).
Note that this also pulls in the breaking release v29.0.0. Supposedly, that release would add spaces between union type items, i. e. turn
{string|number}into{string | number}. However, I tried configuring this new version of the config in MediaWiki core, and it didn’t change any of the union types. I’m not sure if I’m doing something wrong or if there’s actually no change.