[EXPERIMENTAL] Add RTL support with CSSJanus webpack plugin #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is experimental, and is attempting to provide RTL support through the CSSJanus plugin. There are several issues to be fixed, and potentially they may involve redoing some of the entrypoints. While RTL support seems to be working with this out of the box, there might be better ways to do this by making the external libraries (OOUI especially) their own entrypoint since they have their own RTL version already-made in their repos, and then attaching those files independently to the base.html.twig. This is experimental, to see if it's working properly and covers the necessary cases, and can serve as a testbed for seeing whether it is worth expanding to our other tools. If/when we can examine this and determine it's worth using, we can remove the experimental tag and merge. Reference: https://phabricator.wikimedia.org/T208371
mooeypoo
force-pushed
the
experimental-rtl-support-with-cssjanus
branch
from
a28fe36
to
9e79bee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is experimental, and is attempting to provide RTL support through
the CSSJanus plugin.
There are several issues to be fixed, and potentially they may involve
redoing some of the entrypoints. While RTL support seems to be working
with this out of the box, there might be better ways to do this by
making the external libraries (OOUI especially) their own entrypoint
since they have their own RTL version already-made in their repos,
and then attaching those files independently to the base.html.twig.
This is experimental, to see if it's working properly and covers
the necessary cases, and can serve as a testbed for seeing whether
it is worth expanding to our other tools.
If/when we can examine this and determine it's worth using, we
can remove the experimental tag and merge.
Reference: https://phabricator.wikimedia.org/T208371