Universal links handling for places #4549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayesh15111988
force-pushed
the
universal-links-handling-for-places
branch
from
3299dc2
to
d53759b
Compare
jayesh15111988
force-pushed
the
universal-links-handling-for-places
branch
from
d53759b
to
07cc9d5
Compare
tonisevener
requested changes
May 24, 2024
There was a problem hiding this comment.
@jayesh15111988 Thanks for fixing this! I found one bug, let me know what you think. The other changes look good to me.
| @@ -470,7 +470,7 @@ class PlacesViewController: ViewController, UISearchBarDelegate, ArticlePopoverV | |||
| } | |||
|
|
|||
| func performDefaultSearchIfNecessary(withRegion region: MKCoordinateRegion?) { | |||
| guard currentSearch == nil else { | |||
| guard currentSearch == nil, searchBar.text == nil else { | |||
There was a problem hiding this comment.
Is this change necessary? I notice sometimes searchBar.text == "", and it's not performing the default search when it should. This change causes this bug:
- Simulate simulator location to something (Features menu > Location > Apple)
- Fresh install app
- Tap Places tab, tap "Enable location" in popup
- Tap "Allow while using app" in popup
- Map goes to Cupertino, but nearby places are not automatically searched anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
Notes
Test Steps
Added universal link from test app and verified that Wikipedia app successfully open the map view with specified place name. Verified locally.
Screenshots/Videos
Wikipedia_places_accessor_demo_720.mov