Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image recommendations - search field when opening image link fixed #4857

Merged
merged 1 commit into from
May 24, 2024

Conversation

mfvarani
Copy link
Contributor

@mfvarani mfvarani commented May 17, 2024

Phabricator: https://phabricator.wikimedia.org/T363942

Notes

  • Here we are setting the navigation bar to be visible for the controller, but we were missing toggling it back when opening an image link.

Test Steps

  1. Toggle this boolean for being able to get offered the image recommendations feature
  2. Log-in
  3. Tap on the "Add an image" card
  4. Tap on the image link
  5. Tap on the search navigation bar icon

Screenshots/Videos

Before After
before after

Copy link
Collaborator

@tonisevener tonisevener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfvarani Thank you for the fix! Feel free to add your name to our contributors list in a followup PR, if you would like.

@tonisevener tonisevener merged commit a66c00d into wikimedia:main May 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants