This repository has been archived by the owner on Nov 8, 2023. It is now read-only.
[WFLY-17879] Manage version of JUnit for wildfly-ee-with-tools BOM #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't rely on JUnit version brought in transitively and instead explicitly manage it the same way we do with TestNG dependency version.
Support for OpenTracing was removed from recent WildFly
Support for MP Metrics was removed from recent WildFly
bstansberry
approved these changes
Apr 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFLY-17879
There was a change in how test dependencies are managed - https://issues.redhat.com/browse/WFLY-17561 and https://issues.redhat.com/browse/WFCORE-6203 and that caused the BOMs build to fail on missing JUnit version.
The proposal is not to rely on JUnit version being brought in transitively and instead explicitly manage it the same way we do with TestNG dependency version.