Package updates #66
Closed
Package updates #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the new version needs an additional dependency on Ubuntu 18: |
|
Github is already working on it, so I'll skip the Puppeteer update for now and will upgrade once the CI image has the new library. |
cecilemuller
added a commit
to wildpeaks/2019-package-store
that referenced
this pull request
Apr 27, 2020
Puppeteer 3 needs an additional dependency, so I'll remain on 2 until Github Action environments are updated, see wildpeaks/package-snapshot-dom#66 for more infos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
terserand devDependencies.However, the new Puppeteer 3 fails to run on the CI despite the tests run fine locally, so I have to look into this before merging.