-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anj mcp variant #7
Open
jwannebo3524
wants to merge
46
commits into
main
Choose a base branch
from
ANJ_MCP_variant
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idk how it got there. was full of numbers.
remove follower declareation in init
now its debugged for real
very little mistake
fruzyna
requested changes
Jan 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A general note before I start the full review, class names and their corresponding file names should always be in PascalCase, variable names (unless constant/static/final) should be camelCase
Updates pipeline for reflective and Apriltag for Cones and cubes respectively
…11_robot_software into ANJ_MCP_variant
Position PID for the sparkmax can now select which PID slot you want, as well as methods to choose which PID slot you are using and assign values to extra PID slots
@jwaters3457 please fix build errors |
WSSubsystems is now in MCP Variant
smccrorie
requested changes
Feb 6, 2023
src/main/java/org/wildstang/year2023/subsystems/masterControlProgram/MasterControlProgram.java
Outdated
Show resolved
Hide resolved
src/main/java/org/wildstang/year2023/subsystems/masterControlProgram/MasterControlProgram.java
Outdated
Show resolved
Hide resolved
src/main/java/org/wildstang/year2023/subsystems/masterControlProgram/MasterControlProgram.java
Outdated
Show resolved
Hide resolved
smccrorie
reviewed
Feb 11, 2023
src/main/java/org/wildstang/year2023/subsystems/masterControlProgram/MasterControlProgram.java
Show resolved
Hide resolved
[Verse 1] To make you want me I can fabricate the truth I'll give you easy it'll keep me destitute You hang me up on the line, hang me out to dry And you got nothing to lose [Verse 2] You've got the story all made up inside your head You write me out of it and use your words instead You hold me just out of reach, but you keep me pounding the beat To take all the soul you can get [Chorus] You want me to change, change, change You want me to change You want me to change, change, change You want me to change [Verse 3] You take no chances and you give no other choice You fill your pockets and you empty out my voice You use the shallow and old, trade the heart for the gold You sell the song for the noise [Chorus] You want me to change, change, change You want me to change You want me to change, change, change You want me to change You want me to change, change, change You want me to change You want me to change, change, change You want me to change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem: Master Control Program
Description:
Describe your changes in a few sentences.
Added master control program.
Face buttons are goals. shoulders switch between cone/cube mode, but another button must be pressed for them to do anything visable. dpad buttons are for different pickup spots. select and start buttons halt the arm or move arm to default config, I dont remember which is which. Left Joystick is for manual lift control. Moving it all the way down resets lift encoder. Manual lift control might mess up automated procedures.
Tested: No
Collaborators: @dimwitt @dimwitt71 @potatomasqer
Before submitting: