Only monitor running containers. #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffried
reviewed
Aug 12, 2023
docker-entrypoint
Outdated
| then | ||
| running_filter="" | ||
| else | ||
| running_filter=",\"status\":\[\"runing\"\]" |
There was a problem hiding this comment.
Shouldn't this be "running"?
Suggested change
| running_filter=",\"status\":\[\"runing\"\]" | |
| running_filter=",\"status\":\[\"running\"\]" |
There was a problem hiding this comment.
Yeah, I spotted this and changed it in my main branch (which the Dockerhub container is based off), but I've made some other changes in there which won't want merging upstream. I thought I'd edited it in this branch too, but missed it. Should all be good now.
|
Please see the PR #115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change means that containers that are not running (stopping, starting, created, exited, dead and paused) will be filtered out.
It prevents paused containers from being automatically restarted.