General Fixes #56
Open
General Fixes #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimplicityGuy
commented
Jul 16, 2022
•
SimplicityGuy
commented
- cleanup of script based on shellcheck.net
- general reformatting
- updated alpine version
- addressed issues:
- top-level script name is not picked up
- jq parsing errors if some properties are not set
fix: shellcheck fixes
fix: additional fixes
|
@willfarrell Any update on reviewing these changes? |
|
@willfarrell Would appreciate the review. :) |
|
@SimplicityGuy, looking at the age of other PRs for this repo I think development for it is dead. |
|
I agree, @RoboMagus. I've already forked this and am running my own instance. Will maintain it with some additional improvements too. I'll keep this PR open in hope that perhaps it'll be merged someday. I won't publish an official image like @willfarrell did, so folks will need to build their own if they want to use my fork with the fixes. Still need to figure out some logistics on builds and whatnot since I use GitLab for my private Docker repo (better terms for free users). But I'll definitely keep my Github fork alive and up-to-date. |
- removed support for `projects` as the feature was very incomplete and it served little purpose - added support for common settings between jobs using `~~shared-settings` as a key in the config - cleaned up some items that have long bugged me - better reuse of code - better variable naming - improved flow and readability - formatting to the logs
…never worked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.