Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing px of top style #265

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix missing px of top style #265

wants to merge 2 commits into from

Conversation

liumingye
Copy link

alexbarnsley
alexbarnsley reviewed Nov 28, 2022
View reviewed changes
src/bodyScrollLock.js Outdated Show resolved Hide resolved
@liumingye @alexbarnsley
Update src/bodyScrollLock.js
99d8b8f 
Co-authored-by: Alex Barnsley <8069294+alexbarnsley@users.noreply.github.com>
@riddla
Copy link

riddla commented Jan 12, 2023

This fix works for me on iOS 👍

webappcreations
webappcreations approved these changes Jan 15, 2023
View reviewed changes
Copy link

@webappcreations webappcreations left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOPE - Cache didn't update, this fix doesn't seem to work on an iPhone 11 with iOS 16.1.2.
Once the bodyscrolllock is called, the page jumps up top the top of the page.
The only thing working seems to be downgrading to Version 3.1.5

webappcreations

This comment was marked as duplicate.

Sign in to view

@rick-liruixin
Copy link

They stopped the repairs. I had to do it myself, in the same way, with a new version of typeScript. And fix these problems for everyone to use. add react hooks、vue3 example

npm i body-scroll-lock-upgrade

repair log，Refer to the releases page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbarnsley alexbarnsley alexbarnsley left review comments

@webappcreations webappcreations webappcreations approved these changes

@plcdnl plcdnl plcdnl approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@liumingye @riddla @rick-liruixin @alexbarnsley @webappcreations @plcdnl