Don't attempt to minify script/style tags with no content
#186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more common with `script` tags, where most uses will reference external script files than inline scripts. Skipping this, even when JS / CSS minification is enabled avoids the need to spin up the minification libraries entirly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more common with
scripttags, where most uses will reference external script files than inline scripts.Skipping this, even when JS / CSS minification is enabled avoids the need to spin up the minification libraries entirly.
I've intentionally made the code change here, rather than where
ScriptOrStyleContentis determined, as the code change was significantly smaller with the same effect.