Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cypress to 13.2.0 #53

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Update cypress to 13.2.0 #53

merged 3 commits into from
Oct 4, 2023

Conversation

wimdetroyer
Copy link
Contributor

Update testcontainers to 1.19.0
Add mac troubleshooting section

Update testcontainers to 1.19.0
Add mac troubleshooting section
@wimdetroyer
Copy link
Contributor Author

I have tested this update on our end, and everything seems to work. Great job on this library!

Due to testcontainers/testcontainers-java#7421 I also had to make some changes in the tests.

If you think this PR is OK to be merged into the master branch, would you be so kind to label this PR with 'hacktoberfest-accepted' please? https://hacktoberfest.com/ is currently going on.

README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
@wimdeblauwe
Copy link
Owner

Thank you for this PR! If you can update the versions to the latest ones available, we can merge this and I can do a new release.

@wimdeblauwe wimdeblauwe added this to the 1.9.0 milestone Oct 3, 2023
Update testcontainers to 1.19.1
Add mac troubleshooting section
@wimdetroyer
Copy link
Contributor Author

I've bumped the versions again and did a test again on our project. Everything still seems to work 😃

I didn't find a way to squash the commits in this PR though. Apparently you can't do that if you fork a repo ?

Will you be able to squash to a clean commit? If not I can just reopen a new PR

@wimdeblauwe wimdeblauwe merged commit d7973f1 into wimdeblauwe:master Oct 4, 2023
2 checks passed
@wimdeblauwe
Copy link
Owner

No worries. I was able to squash. Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants