add huoshan translate service #780
Open
+147
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add huoshan translate service
fix: fix 443, add huoshan translate service
windingwind
reviewed
Apr 10, 2024
package.json
Outdated
| @@ -35,6 +35,7 @@ | |||
| "franc": "^6.1.0", | |||
| "iso639-js": "^1.1.3", | |||
| "jsencrypt": "^3.3.2", | |||
| "volcengine-sdk": "^0.0.2", | |||
There was a problem hiding this comment.
volcengine-sdk is not actively maintained. Any reason to choose this package?
There was a problem hiding this comment.
在新的提交中，我按照volcengine-sdk中的方法使用crypto-js替代了volcengine-sdk
typings/global.d.ts
Outdated
| @@ -12,6 +12,8 @@ declare const _globalThis: { | |||
| addon: typeof addon; | |||
| }; | |||
|
|
|||
| declare module "volcengine-sdk"; | |||
The encryption algorithm in volcengine-sdk is implemented using crypto-js
删除了volcengine-sdk依赖
|
整体ok，两个小建议/问题：
|
在之后我尝试使用crypto.ts重写 |
add crypto-js dependencies
在使用crypto.ts时，它的hmacSha256Digest返回的为一个Promise，而crypto-js中HmacSHA256返回的是一个object，我不知道要怎样解决，所以暂时在package.json添加了crypto-js依赖 |
Promise是JavaScript的原生对象，用于异步。可通过类似 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add huoshan translate service