Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dev node version to fix intermittent fetch errors #5866

Merged
merged 2 commits into from Mar 8, 2024

Conversation

MarkMcCulloh
Copy link
Contributor

@MarkMcCulloh MarkMcCulloh commented Mar 7, 2024

Updates node used in workflow and for local dev from 20.11.0 to 20.11.1

Also removes an SDK test, per reasoning from #5856

Fixes #5734

See 12 successful runs in a row (fully uncached):

It actually succeeded more than that, but this is the cleanest list

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

Copy link

github-actions bot commented Mar 7, 2024

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @eladb
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@monadabot
Copy link
Contributor

monadabot commented Mar 7, 2024

Console preview environment is available at https://wing-console-pr-5866.fly.dev 🚀

Last Updated (UTC) 2024-03-08 17:17

@monadabot
Copy link
Contributor

monadabot commented Mar 7, 2024

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜🟩⬜⬜🟩🟩
Benchmark Before After Change
version 58ms±0.76 59ms±0.71 +1ms (+2.24%)⬜
functions_1.test.w -t sim 516ms±11.55 521ms±7.19 +5ms (+0.99%)⬜
functions_1.test.w -t tf-aws 942ms±9.54 954ms±8.35 +12ms (+1.3%)⬜
jsii_small.test.w -t sim 486ms±6.69 496ms±8.04 +10ms (+2.02%)⬜
jsii_small.test.w -t tf-aws 709ms±5.01 716ms±6.91 +7ms (+0.97%)⬜
jsii_big.test.w -t sim 2892ms±5.74 2899ms±10.25 +7ms (+0.25%)⬜
jsii_big.test.w -t tf-aws 3115ms±13.65 3122ms±16.8 +7ms (+0.23%)⬜
hello_world.test.w -t sim 527ms±5.82 520ms±6.01 -7ms (-1.3%)⬜
hello_world.test.w -t tf-aws 1666ms±9.8 1645ms±8.15 -21ms (-1.24%)🟩
empty.test.w -t sim 493ms±6.41 485ms±5.05 -8ms (-1.54%)⬜
empty.test.w -t tf-aws 714ms±4.6 704ms±5.17 -10ms (-1.45%)⬜
functions_10.test.w -t sim 607ms±6.51 587ms±6.79 -20ms (-3.27%)🟩
functions_10.test.w -t tf-aws 2264ms±11.76 2219ms±9.12 -45ms (-1.98%)🟩

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 59ms 58ms 61ms 1ms 1ms
functions_1.test.w -t sim 521ms 507ms 544ms 7ms 10ms
functions_1.test.w -t tf-aws 954ms 936ms 973ms 8ms 12ms
jsii_small.test.w -t sim 496ms 481ms 511ms 8ms 11ms
jsii_small.test.w -t tf-aws 716ms 708ms 740ms 7ms 10ms
jsii_big.test.w -t sim 2899ms 2875ms 2927ms 10ms 14ms
jsii_big.test.w -t tf-aws 3122ms 3097ms 3174ms 17ms 23ms
hello_world.test.w -t sim 520ms 509ms 532ms 6ms 8ms
hello_world.test.w -t tf-aws 1645ms 1631ms 1666ms 8ms 11ms
empty.test.w -t sim 485ms 476ms 496ms 5ms 7ms
empty.test.w -t tf-aws 704ms 695ms 717ms 5ms 7ms
functions_10.test.w -t sim 587ms 568ms 598ms 7ms 9ms
functions_10.test.w -t tf-aws 2219ms 2192ms 2237ms 9ms 13ms
Last Updated (UTC) 2024-03-08 17:22

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Mar 7, 2024
@MarkMcCulloh MarkMcCulloh removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Mar 7, 2024
@MarkMcCulloh MarkMcCulloh changed the title chore: debugging CI socket issue chore: update dev node version to fix intermittent fetch errors Mar 8, 2024
@MarkMcCulloh MarkMcCulloh marked this pull request as ready for review March 8, 2024 17:23
@MarkMcCulloh MarkMcCulloh requested a review from a team as a code owner March 8, 2024 17:23
Copy link
Contributor

mergify bot commented Mar 8, 2024

Thanks for contributing, @MarkMcCulloh! This PR will now be added to the merge queue, or immediately merged if mark/try-stuff is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit dbe7de9 into main Mar 8, 2024
21 checks passed
@mergify mergify bot deleted the mark/try-stuff branch March 8, 2024 18:08
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.59.46.

@staycoolcall911
Copy link
Contributor

Sweet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flakey redis test in CI (TypeError: fetch failed caused by SocketError: other side closed)
4 participants