Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: typescript and esm in preflight #6157

Merged
merged 23 commits into from
Apr 12, 2024
Merged

feat: typescript and esm in preflight #6157

merged 23 commits into from
Apr 12, 2024

Conversation

MarkMcCulloh
Copy link
Contributor

@MarkMcCulloh MarkMcCulloh commented Apr 5, 2024

Fixes #3013

Allows the use of .ts and esm-based extern files

  • Check benchmarks to make sure happy path perf isn't hurt
  • Windows
  • Add e2e test to verify fix for "type": "module" Doesn't fix that issue anymore
  • Docs to officially sanction using ts in both preflight and inflight via extern

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

Copy link

github-actions bot commented Apr 5, 2024

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@monadabot
Copy link
Contributor

monadabot commented Apr 5, 2024

Console preview environment is available at https://wing-console-pr-6157.fly.dev 🚀

Last Updated (UTC) 2024-04-12 13:50

@monadabot
Copy link
Contributor

monadabot commented Apr 5, 2024

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜🟥🟩🟥🟥🟥⬜
Benchmark Before After Change
version 59ms±0.95 59ms±0.48 +0ms (+0.49%)⬜
functions_1.test.w -t sim 389ms±10.79 399ms±3.07 +10ms (+2.54%)⬜
functions_1.test.w -t tf-aws 822ms±7.77 826ms±9.91 +5ms (+0.58%)⬜
hello_world.test.w -t sim 387ms±6.7 404ms±9.62 +17ms (+4.37%)⬜
hello_world.test.w -t tf-aws 1522ms±16.7 1514ms±18.92 -8ms (-0.5%)⬜
jsii_big.test.w -t sim 2784ms±12.62 2769ms±17.21 -15ms (-0.52%)⬜
jsii_big.test.w -t tf-aws 2997ms±8.09 2986ms±15.26 -10ms (-0.35%)⬜
functions_10.test.w -t sim 469ms±7.96 490ms±8.85 +21ms (+4.46%)🟥
functions_10.test.w -t tf-aws 2125ms±16.61 1992ms±5.52 -134ms (-6.29%)🟩
jsii_small.test.w -t sim 356ms±6.38 374ms±4.35 +18ms (+5.14%)🟥
jsii_small.test.w -t tf-aws 590ms±4.15 612ms±9.36 +23ms (+3.85%)🟥
empty.test.w -t sim 350ms±4.69 364ms±3.83 +14ms (+4.01%)🟥
empty.test.w -t tf-aws 585ms±5.33 587ms±4.8 +2ms (+0.38%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 59ms 58ms 60ms 0ms 1ms
functions_1.test.w -t sim 399ms 389ms 403ms 3ms 4ms
functions_1.test.w -t tf-aws 826ms 804ms 848ms 10ms 14ms
hello_world.test.w -t sim 404ms 388ms 434ms 10ms 13ms
hello_world.test.w -t tf-aws 1514ms 1493ms 1570ms 19ms 26ms
jsii_big.test.w -t sim 2769ms 2745ms 2815ms 17ms 24ms
jsii_big.test.w -t tf-aws 2986ms 2952ms 3016ms 15ms 21ms
functions_10.test.w -t sim 490ms 471ms 508ms 9ms 12ms
functions_10.test.w -t tf-aws 1992ms 1981ms 2006ms 6ms 8ms
jsii_small.test.w -t sim 374ms 363ms 384ms 4ms 6ms
jsii_small.test.w -t tf-aws 612ms 598ms 639ms 9ms 13ms
empty.test.w -t sim 364ms 357ms 374ms 4ms 5ms
empty.test.w -t tf-aws 587ms 577ms 600ms 5ms 7ms
Last Updated (UTC) 2024-04-12 13:55

monadabot and others added 2 commits April 9, 2024 15:06
Signed-off-by: monada-bot[bot] <monabot@monada.co>
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 9, 2024
@MarkMcCulloh MarkMcCulloh removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 10, 2024
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 10, 2024
Signed-off-by: monada-bot[bot] <monabot@monada.co>
@MarkMcCulloh MarkMcCulloh removed ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! 🧪 pr/e2e-full labels Apr 10, 2024
@winglang winglang deleted a comment from monadabot Apr 10, 2024
monadabot and others added 2 commits April 10, 2024 13:48
Signed-off-by: monada-bot[bot] <monabot@monada.co>
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 10, 2024
@MarkMcCulloh MarkMcCulloh removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 10, 2024
@winglang winglang deleted a comment from monadabot Apr 10, 2024
@MarkMcCulloh MarkMcCulloh marked this pull request as ready for review April 10, 2024 23:52
@MarkMcCulloh MarkMcCulloh requested a review from a team as a code owner April 10, 2024 23:52
examples/tests/invalid/extern_static.test.w Outdated Show resolved Hide resolved
Copy link
Contributor

mergify bot commented Apr 12, 2024

Thanks for contributing, @MarkMcCulloh! This PR will now be added to the merge queue, or immediately merged if mark/jiti is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit 71e8fc7 into main Apr 12, 2024
15 checks passed
@mergify mergify bot deleted the mark/jiti branch April 12, 2024 13:56
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.70.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using ESM in external preflight function fails
4 participants