Display core parking indicator when hovering the mouse over the processor graphs #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
jxy-s
reviewed
Apr 24, 2024
There was a problem hiding this comment.
@wnstngs thanks for the contribution! I agree with showing the parked state in the tooltip. I have some feedback. Either I can merge this as and and go back to address it myself, or you can do so. Let me know how you'd like to handle it.
… Don't pass a handle to a process as we aren't interested in whether CPU set is allocated to any process (the indirected handle still has to be valid and point to 0).
…ffset to the next set when iterating CPU sets instead of indexing.
jxy-s
approved these changes
May 14, 2024
dmex
approved these changes
May 16, 2024
|
@jxy-s Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Starting with Windows 7, the thread scheduler and processor power manager are able to park processors for power saving purposes. Parking a processor makes it unavailable for thread scheduling, which contributes to potentially putting this processor into a deep idle state and thus reducing power consumption. Parked cores are marked as "Parked" in Task Manager, but not in System Informer.
This PR adds support for displaying core parking status in the tooltip when hovering over the processor graphs. Previously there was a proposal to add such a feature: #1083
Proposed changes
TODO?
formatindexes change depending on different conditions). For example, at least use named variables for indexes of certain components of the tooltip (load percentages, relationships, time, and so on).