Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Blob and File #19

Merged
merged 1 commit into from Dec 1, 2022
Merged

Add Blob and File #19

merged 1 commit into from Dec 1, 2022

Conversation

jasnell
Copy link
Contributor

@jasnell jasnell commented Jun 1, 2022 •
edited

Closes: #17

@andreubotella
Copy link
Member

andreubotella commented Nov 3, 2022 •
edited

The File API spec hasn't been well maintained for some time, and there are a couple long-standing issues where it's known to be broken (such as w3c/FileAPI#43). However, since FormData requires Blob and File, and there's no other way to have files in multipart/form-data (short of actually implementing the serialization or parsing manually), I guess adding them is better than not.

Ethan-Arrowood
Ethan-Arrowood approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This are requirements for other things like Fetch. Definitely should be in here

@jasnell jasnell merged commit d8d753c into main Dec 1, 2022
@jasnell jasnell deleted the add-blob-file branch December 1, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blob and File
3 participants
@jasnell @andreubotella @Ethan-Arrowood