feat: Allow unknown commit types #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffflorian
commented
Dec 10, 2018
| @@ -4,7 +4,7 @@ var Bluebird = require('bluebird'); | |||
| var CP = Bluebird.promisifyAll(require('child_process')); | |||
|
|
|||
| var SEPARATOR = '===END==='; | |||
| var COMMIT_PATTERN = /^(\w*)(?:\(([^)]*?)\)|):(.*?(?:\[([^\]]+?)\]|))\s*$/; | |||
| var COMMIT_PATTERN = /^([^)]*)(?:\(([^)]*?)\)|):(.*?(?:\[([^\]]+?)\]|))\s*$/; | |||
There was a problem hiding this comment.
This change is needed to make sure unknown commit types like run-fix(core): Implement something works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking over from lob#46.
This PR will
Reason
Sometimes you want to use other commit types in your repository (e.g.
run-fixto mark fixes concerning only the current feature run). These should not all be grouped into "Other changes" then.Result
Commits with unknown types will then be each grouped into
Other changes (<commit type>).Example
New Features
Other Changes (run-fix)