fix(react-ui-kit): select types #4353
Conversation
| id: string; | ||
| dataUieName: string; | ||
| options: Option[]; | ||
| onChange: (value: Option) => void; |
There was a problem hiding this comment.
Isn't the value Option[] when select is IsMulti?
There was a problem hiding this comment.
You will have always single option on change click, if you can check it on MLS using this: https://wearezeta.atlassian.net/wiki/spaces/WEB/pages/567214882/Updating+dependencies+packages+in+development+Yalc ?
There was a problem hiding this comment.
that is incorrect from my testing.. for multi select it passes all
There was a problem hiding this comment.
that's what I assumed as well when talking to @przemvs
| @@ -31,16 +31,17 @@ import type {Theme} from '../Layout'; | |||
| import InputLabel from './InputLabel'; | |||
|
|
|||
| export type Option = { | |||
| value: string | number; | |||
| value: string; | |||
There was a problem hiding this comment.
the value will sometimes be a number
There was a problem hiding this comment.
Sure, but you can replace this value from string to number :) I talked about this with @aweiss-dev .
There was a problem hiding this comment.
in what case do we return a number? when we talk about inputs the input value will always be a string. unless the input event value gets manipulated before reaching the onChange
There was a problem hiding this comment.
cipher suites need to be a number for the BE to work
There was a problem hiding this comment.
But that gets done from the onChange handler right? The option and the onChange on the select are supposed to work with strings
There was a problem hiding this comment.
sorry i missed this mesage but yea thats fine also
| @@ -31,16 +31,17 @@ import type {Theme} from '../Layout'; | |||
| import InputLabel from './InputLabel'; | |||
|
|
|||
| export type Option = { | |||
| value: string | number; | |||
| value: string; | |||
There was a problem hiding this comment.
cipher suites need to be a number for the BE to work
|
|
Pull Request Checklist