Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runfix: check if IndexDB enabled in FireFox and extend the message in "Unsupported browser" page WPB-8820 #17350

Merged
merged 6 commits into from May 13, 2024
Merged

runfix: check if IndexDB enabled in FireFox and extend the message in "Unsupported browser" page WPB-8820 #17350

merged 6 commits into from May 13, 2024

Conversation

svitovyda
Copy link
Contributor

@svitovyda svitovyda commented May 3, 2024 •
edited by github-actions bot

BugWPB-8820 [web] The unsupported browser page is broken

Description

  • Fix check of IndexDB in FireFox private mode (was broken);
  • Add console logs to identify which part of browser feature support triggered;
    - Message in "Unsupported browser" includes settings for cookies and IndexDB;
  • Messages in "Unsupported browser" page is up to date with our product/design/copy team and are final;

Screenshots/Screencast (for UI changes)

Checklist

  • PR has been self reviewed by the author;

Important details for the reviewers

@svitovyda svitovyda requested review from otto-the-bot and a team as code owners May 3, 2024 20:13
@CLAassistant
Copy link

CLAassistant commented May 3, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024 •
edited

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 46.08%. Comparing base (3d4a120) to head (d5dcb37).

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #17350      +/-   ##
==========================================
- Coverage   46.09%   46.08%   -0.01%     
==========================================
  Files         753      753              
  Lines       24725    24728       +3     
  Branches     5667     5668       +1     
==========================================
- Hits        11397    11396       -1     
- Misses      11898    11903       +5     
+ Partials     1430     1429       -1

@svitovyda svitovyda force-pushed the fix/WPB-8820-unsupported-browser-features branch from 904a916 to 0d2dc5a Compare May 3, 2024 20:19
@svitovyda svitovyda force-pushed the fix/WPB-8820-unsupported-browser-features branch from bb1f1fb to f6bb62d Compare May 6, 2024 16:59
@svitovyda svitovyda force-pushed the fix/WPB-8820-unsupported-browser-features branch from f6bb62d to 294b2ac Compare May 10, 2024 14:28
tlebon
tlebon reviewed May 13, 2024
View reviewed changes
src/page/unsupported.ejs Outdated
@@ -130,24 +134,25 @@
</header>
<main style="flex: 1 1 0; padding-left: 8px; width: 100%;">
<div class="textContent">
<h2 data-uie-name="element-unsupported-headline">This browser is not supported.</h2>
<h2 data-uie-name="element-unsupported-headline">Wire doesn't support this browser.</h2>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should all be new translation strings

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a separate ticket for localization of the strings in the "Unsupported browser" page, we agreed with Tom and Sascha to implement it hardcoded EN for now and think about configuring the link URL and translation later.
Since this one should be the simplest plain HTML that can be shown in any oldest browser possible and it has no scripts at all, it might be really difficult to implement the usage of intl here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://wearezeta.atlassian.net/browse/WPB-9005 - the translation ticket

tlebon
tlebon requested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@tlebon tlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the translations please and lets see if we can come up with a better solution than console log

@svitovyda svitovyda force-pushed the fix/WPB-8820-unsupported-browser-features branch from 1ac7778 to 9d624c9 Compare May 13, 2024 10:55
@svitovyda svitovyda force-pushed the fix/WPB-8820-unsupported-browser-features branch from f74a859 to 63b4b49 Compare May 13, 2024 13:55
@svitovyda @V-Gira
Update src/script/browser/CheckBrowser.ts
d5dcb37 
Co-authored-by: Virgile <78490891+V-Gira@users.noreply.github.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@svitovyda svitovyda changed the title fix: the check if IndexDB enabled in FireFox and extend the message in "Unsupported browser" page runfix: check if IndexDB enabled in FireFox and extend the message in "Unsupported browser" page May 13, 2024
@svitovyda svitovyda merged commit 6bc8f5e into dev May 13, 2024
12 of 13 checks passed
@svitovyda svitovyda deleted the fix/WPB-8820-unsupported-browser-features branch May 13, 2024 15:23
@svitovyda svitovyda changed the title runfix: check if IndexDB enabled in FireFox and extend the message in "Unsupported browser" page runfix: check if IndexDB enabled in FireFox and extend the message in "Unsupported browser" page WPB-8820 May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlebon tlebon tlebon approved these changes

@V-Gira V-Gira V-Gira approved these changes

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

@PatrykBuniX PatrykBuniX Awaiting requested review from PatrykBuniX

Assignees
No one assigned
Labels
👕 size: M type: bug / fix 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@svitovyda @CLAassistant @codecov-commenter @tlebon @PatrykBuniX @V-Gira @otto-the-bot