Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unread message clearing on convo change #17380

Merged
merged 5 commits into from May 13, 2024
Merged

Conversation

tlebon
Copy link
Contributor

@tlebon tlebon commented May 8, 2024

Description

Noticed an issue where unread messages would be cleared when changing conversations and going back to the original convo.
Appears to be a regression introduced in #17158

Screenshots/Screencast (for UI changes)

Before:
https://github.com/wireapp/wire-webapp/assets/37285713/65fb81b5-93d7-4222-8b96-f63004aba8c2

After:
https://github.com/wireapp/wire-webapp/assets/37285713/772f3419-4049-474a-a0cb-f3228eefb053

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.07%. Comparing base (3c78c48) to head (ea7eb83).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #17380      +/-   ##
==========================================
+ Coverage   46.05%   46.07%   +0.01%     
==========================================
  Files         753      753              
  Lines       24736    24737       +1     
  Branches     5669     5669              
==========================================
+ Hits        11392    11397       +5     
+ Misses      11913    11910       -3     
+ Partials     1431     1430       -1     

Copy link

sonarcloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@PatrykBuniX PatrykBuniX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tlebon tlebon merged commit 3d4a120 into dev May 13, 2024
11 checks passed
@tlebon tlebon deleted the fix/unread-messages-clearing branch May 13, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants