Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runfix: multiple proteus 1:1 conversations with a team member [WPB-9063] #17382

Merged
merged 4 commits into from May 13, 2024

Conversation

PatrykBuniX
Copy link
Contributor

@PatrykBuniX PatrykBuniX commented May 9, 2024

BugWPB-9063 [Web] Can't open 1:1 chat anymore after receiving a heic image

Description

Due to some bug in the past, it's possible to have two (or more) proteus 1:1 conversations with a team member (since they are really group conversations with some special configuration).

When opening a conversation, instead of finding a conversation with a matching user, try search by the known conversation id.

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 46.09%. Comparing base (3c78c48) to head (a05210a).
Report is 19 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #17382      +/-   ##
==========================================
+ Coverage   46.05%   46.09%   +0.04%     
==========================================
  Files         753      753              
  Lines       24736    24725      -11     
  Branches     5669     5667       -2     
==========================================
+ Hits        11392    11398       +6     
+ Misses      11913    11898      -15     
+ Partials     1431     1429       -2     

@PatrykBuniX PatrykBuniX marked this pull request as ready for review May 9, 2024 10:45
@PatrykBuniX PatrykBuniX requested review from otto-the-bot and a team as code owners May 9, 2024 10:45
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@PatrykBuniX PatrykBuniX changed the title runfix: multiple proteus 1:1 conversations with a team member runfix: multiple proteus 1:1 conversations with a team member [WPB-9063] May 13, 2024
@PatrykBuniX PatrykBuniX merged commit 88e2b22 into dev May 13, 2024
13 checks passed
@PatrykBuniX PatrykBuniX deleted the runfix/1-to-1-team-member branch May 13, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants