New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Jump to last message WPB-6518 #17386
base: dev
Are you sure you want to change the base?
Conversation
isVisible: boolean; | ||
} | ||
|
||
export interface LastMessageTrackerProps extends HTMLProps<HTMLElement> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a separate component as we want to avoid the entire content of Conversation
to re-render each time messages are scrolled and messages visibility changes
@@ -88,6 +89,7 @@ export const Message: React.FC<MessageParams & {scrollTo?: ScrollToElement}> = p | |||
isHighlighted, | |||
hideHeader, | |||
onVisible, | |||
onVisibilityChange, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is weird, but as isVisible
was implemented till now, it would be triggered only the first time (and if it's added as the item of the list one by one, and then disappear from the visible area - it will still be called). I don't mind merging them at least on the Message
and the level of its usage, but I want to hear your opinions on how to do it the best
70bff5b
to
caec31b
Compare
…sage; Mark all the conversation as read on the "jump to last message" button click; Reload the conversation on the "jump to last message" click if the latest conversation messages were not load;
caec31b
to
691c0bc
Compare
Quality Gate passedIssues Measures |
Description
By the product/design team request, the user should jump to the very last message in the conversation, marking all the messages as read
Screenshots/Screencast (for UI changes)
Checklist
Important details for the reviewers
(Delete this section if unnecessary)