Use verbose flag for more Makefile targets #8
Conversation
| @@ -17,7 +17,7 @@ coverage: | |||
|
|
|||
| .PHONY: doc | |||
| doc: | |||
| python3 -c "import PIL" > /dev/null 2>&1 || python3 -m pip install . | |||
There was a problem hiding this comment.
Don't see that this one is important.
| @@ -49,7 +49,7 @@ help: | |||
|
|
|||
| .PHONY: inplace | |||
| inplace: clean | |||
| python3 -m pip install -e --global-option="build_ext" --global-option="--inplace" . | |||
There was a problem hiding this comment.
I'm not a fan of inplace anyway, I'd rather this option went away as it's broken when you have virtual envs or more than one python you're testing. It's safer to have things that always work than ones that sometimes work.
|
|
||
| .PHONY: release-test | ||
| release-test: | ||
| python3 -m pip install -e .[tests] |
There was a problem hiding this comment.
This is a release time smoke test. It's up to the release managers to say if they want the verbose here.
There was a problem hiding this comment.
I've never needed to pay attention in detail to the output of this. I don't need verbose, but don't oppose it if anyone wants it. (It might push something useful off the top of the logs buffer.)
| @@ -67,14 +67,14 @@ debug: | |||
| # for our stuff, kills optimization, and redirects to dev null so we | |||
| # see any build failures. | |||
| make clean > /dev/null | |||
| CFLAGS='-g -O0' python3 -m pip install --global-option="build_ext" . > /dev/null | |||
There was a problem hiding this comment.
I'm not sure of the /dev/null bit here, but -v makes sense here.
|
Thanks for the comments. I've pushed just the 'debug' change. |
Suggestion for python-pillow#6713